Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SLE Micro system to access free SLES repositories #1247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Nov 14, 2024

Description

A SLE Micro system must have access to all free SLES repositories

This Fixes bsc#1230419

How to test

On a SLE Micro PAYG instance, configured according to the documentation to use Podman,
running zypper lr inside the container should show SLES repositories

On a SUMA 5.0 instance, activating SUMA 4.3 should also activate the recommended SLES repositories

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

A SLE Micro system must have access to all free SLES repositories

This Fixes bsc#1230419
@jesusbv jesusbv self-assigned this Nov 14, 2024
@digitaltom
Copy link
Member

You are defining, based on the product identifier of the registered base product, to infer which other products / repositories the system can use. That works, but is a lot of manual setup.

Maybe there is an automatic way to find out that information, in the way how SCC is doing this:
In SCC, the used subscription of the base product has a list of product classes. The system then has 'permission' to use all products that have a product class of that list. Example: a SUMA subscription includes the product classes of SLES (7261), SLE Micro (MICROOS-X86).

We have a manual config to build that connection for test subscriptions: https://github.com/SUSE/happy-customer/blob/master/glue/config/multi_product_classes.yml

Just an idea, maybe this is a less manual, and more aligned with SCC way how to define access permission.

@jesusbv
Copy link
Collaborator Author

jesusbv commented Nov 15, 2024

You are defining, based on the product identifier of the registered base product, to infer which other products / repositories the system can use. That works, but is a lot of manual setup.

Maybe there is an automatic way to find out that information, in the way how SCC is doing this: In SCC, the used subscription of the base product has a list of product classes. The system then has 'permission' to use all products that have a product class of that list. Example: a SUMA subscription includes the product classes of SLES (7261), SLE Micro (MICROOS-X86).

We have a manual config to build that connection for test subscriptions: https://github.com/SUSE/happy-customer/blob/master/glue/config/multi_product_classes.yml

Just an idea, maybe this is a less manual, and more aligned with SCC way how to define access permission.

@digitaltom It is a good idea, however, when I tested that, the subscription identifier in the activated products for the stand-alone SLE Micro (not SUMA) system was nil

@@ -12,7 +12,13 @@ def activate
end

def show
if @system.products.include? @product
if @product.identifier.casecmp('sles').zero?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no positive test here we can do? It feels inefficient to say "if it's not sles maybe it's sle-micro".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants